Repository navigation
fix: split Init Mode into two phases with ask_user gate (#66) - #72
Merged
Merged
Conversation
Root cause: Init Mode numbered list triggers LLM completion impulse — model executes all steps in one turn, skipping confirmation at step 5. - Split Init Mode into Phase 1 (propose) and Phase 2 (create) - Step 5 now uses ask_user tool with choices for selectable menu - Added explicit STOP gate between Phase 1 and Phase 2 - Added Init Mode exception to Eager Execution Philosophy - New test file: test/init-flow.test.js (8 tests) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
bradygaster
added a commit
that referenced
this pull request
Feb 27, 2026
…ed to squad-pr Session: 2026-02-21-spike-research Requested by: Scribe Changes: - Logged Kujan spikes #66 (model selection), #67 (compaction), #70 (rate limiting), #71 (telemetry) - Logged Fenster spike #72 (config schema expressiveness validation) - Logged Strausz spike #68 (platform surface compatibility) - Merged 6 decision inbox files into decisions.md - Deleted 6 inbox files post-merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66 — Squad init consistently skips user confirmation before creating the team.
Root Cause
Five reinforcing factors cause the LLM to skip the confirmation step:
On confirmation, create filesreads as a soft gate(or skip)allow implicit-yes interpretationFix
Two-phase Init Mode split
ask_usertool call and explicit STOP instructionask_user with selectable choices
ask_usertool with achoicesarray:["Yes, hire this team", "Add someone", "Change a role"]Eager Execution exception
Changes
.github/agents/squad.agent.md— split Init Mode, added STOP gate, added Eager Execution exceptiontest/init-flow.test.js— 8 new regression tests verifying prompt structureTesting
All 53 tests pass (8 new + 45 existing):
ask_userreferenced in Phase 1